fix: Revert "fix(Dashboard): Only apply changes when editing properties" #17618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geido
changed the title
michael-s-molina
approved these changes
Dec 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #17618 +/- ##
==========================================
+ Coverage 68.36% 68.55% +0.18%
==========================================
Files 1601 1601
Lines 65260 65260
Branches 6963 6963
==========================================
+ Hits 44616 44737 +121
+ Misses 18754 18633 -121
Partials 1890 1890
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
🏷️ 2021.46 |
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Dec 1, 2021
…pache#17392)" (apache#17618) This reverts commit 0712be4. (cherry picked from commit 8963cca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #17392
We found that the
onlyApplytag was only partially working as the implementation was partial in both the frontend and the backend. I am working on the full implementation here #17570. However, we should revert the #17392 PR in the meantime to avoid issues with the upcoming release.